[
https://issues.apache.org/jira/browse/PHOENIX-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366005#comment-14366005
]
ASF GitHub Bot commented on PHOENIX-1712:
-----------------------------------------
Github user gabrielreid commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/47#discussion_r26612452
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/InstrFunction.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.expression.function;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
+import org.apache.phoenix.expression.Expression;
+import org.apache.phoenix.parse.FunctionParseNode.Argument;
+import org.apache.phoenix.parse.FunctionParseNode.BuiltInFunction;
+import org.apache.phoenix.schema.SortOrder;
+import org.apache.phoenix.schema.tuple.Tuple;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.schema.types.PInteger;
+import org.apache.phoenix.schema.types.PVarchar;
+import org.apache.phoenix.util.StringUtil;
+
+@BuiltInFunction(name=InstrFunction.NAME, args={
+ @Argument(allowedTypes={ PVarchar.class }),
+ @Argument(allowedTypes={ PVarchar.class })})
+public class InstrFunction extends ScalarFunction{
+
+ public static final String NAME = "INSTR";
+
+ private String strToSearch;
+
+ public InstrFunction() { }
+
+ public InstrFunction(List<Expression> children, String strToSearch) {
+ super(children);
+ setStrToSearch(strToSearch);
+ }
+
+
+ private Expression getStringExpression() {
+ return children.get(0);
+ }
+
+
+ @Override
+ public boolean evaluate(Tuple tuple, ImmutableBytesWritable ptr) {
+ Expression child = getStringExpression();
+ if (!child.evaluate(tuple, ptr)) {
+ return false;
+ }
+
+ int position;
+ //Logic for Empty string search
+ if(strToSearch.length()==0){
+ position = 0;
+ ptr.set(PInteger.INSTANCE.toBytes(position));
+ return true;
+ }
+
+
+ byte [] strPattern = strToSearch.getBytes();
+ SortOrder sortOrder = child.getSortOrder();
+ ImmutableBytesWritable str = new
ImmutableBytesWritable(strPattern);
+
+ position = searchString(ptr,str,sortOrder,strPattern);
+
+ ptr.set(PInteger.INSTANCE.toBytes(position));
+ return true;
+ }
+
+ @Override
+ public PDataType getDataType() {
+ return PInteger.INSTANCE;
+ }
+
+ @Override
+ public String getName() {
+ return NAME;
+ }
+
+ public String getStrToSearch() {
--- End diff --
The getter and setter for strToSearch probably isn't necessary (this value
is only used internally) so it can probably removed.
> Implementing INSTR function
> ---------------------------
>
> Key: PHOENIX-1712
> URL: https://issues.apache.org/jira/browse/PHOENIX-1712
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Naveen Madhire
> Assignee: Naveen Madhire
> Priority: Minor
> Original Estimate: 40h
> Remaining Estimate: 40h
>
> This is sub-task to implement a custom INSTR function just like in Oracle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
