[
https://issues.apache.org/jira/browse/PHOENIX-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368671#comment-14368671
]
ASF GitHub Bot commented on PHOENIX-1712:
-----------------------------------------
Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/47#issuecomment-83401354
@naveenmadhire the added test cases look good, but it looks like your
most-recent commit also removed the integration test.
The integration test should include a test like before (basically checking
that the function works in a real use case), as well as checking that it works
when used as a filter, something like:
select * from table t where instr(t.value, 'test') > 5
> Implementing INSTR function
> ---------------------------
>
> Key: PHOENIX-1712
> URL: https://issues.apache.org/jira/browse/PHOENIX-1712
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Naveen Madhire
> Assignee: Naveen Madhire
> Priority: Minor
> Original Estimate: 40h
> Remaining Estimate: 40h
>
> This is sub-task to implement a custom INSTR function just like in Oracle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
