[ 
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662471#comment-14662471
 ] 

ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------

Github user JeffreyLyonsD2L commented on the pull request:

    https://github.com/apache/phoenix/pull/104#issuecomment-128835914
  
    Thanks for all the feedback @elilevine and @samarthjain! I'm east coast, so 
I'm just heading out of the office now, but I should be able to get the changes 
up sometime tomorrow.
    
    The above question kind of goes outside my realm of interaction with 
Phoenix so I'm not sure if my handle on it is correct. Is the point of the 
TenantId in a table like System.Catalog to tie specific schema to a tenant? If 
so I would lean toward leaving as VARCHAR since any TenantId has to be at least 
convertible to a VARCHAR since it comes down the connection as one, though I 
agree the your 'correct' solution seems like the most complete way forward.


> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
>                 Key: PHOENIX-1673
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1673
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.3.0
>            Reporter: Mark Tse
>              Labels: Newbie, multi-tenant
>             Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the 
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data 
> type. The tenant ID from the connection property can be converted based on 
> the data type of the first primary key column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to