[
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662693#comment-14662693
]
ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------
Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-128866480
Yeah, I understand that the feature allows TENANT_ID on data tables to be a
different type. What I'm not sure about is how useful this feature would be in
real life if internally we are treating tenant ids as strings in connections
and system tables anyway. Why not just do the same for data tables, as well
(which is how it is now implemented)? As you mentioned, every type can be
converted to a string and users can do easily do that for data tables.
If we relax type constrains for data tables but not for metadata
tables/connections we are making the implementation of multi-tenancy in phoenix
internally inconsistent. Should be all or nothing IMHO.
> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
> Key: PHOENIX-1673
> URL: https://issues.apache.org/jira/browse/PHOENIX-1673
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.3.0
> Reporter: Mark Tse
> Labels: Newbie, multi-tenant
> Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data
> type. The tenant ID from the connection property can be converted based on
> the data type of the first primary key column.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
