[
https://issues.apache.org/jira/browse/PHOENIX-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746421#comment-14746421
]
James Taylor commented on PHOENIX-1824:
---------------------------------------
Super excited about your work on CALCITE-840, [~elserj]. Nice work.
Regarding the testing, I don't think it's necessary to run the full IT suite
through the query server. Things like indexing and salting are transparent to
whether they came from the thick or thin driver. Plus, some checks we do in
some IT would be problematic as they depend on state that wouldn't be available
in a thin driver client (i.e. accessing object model of cached metadata). Also,
not sure if there are differences in the explain plan you get back with EXPLAIN
<query>, as we do a lot of checking through that mechanism as well.
I'd consider adding tests that try each statement type: SELECT, UPSERT VALUES,
UPSERT SELECT, DELETE, CREATE TABLE/VIEW/INDEX/SEQUENCE, DROP, ALTER TABLE,
etc, (see http://phoenix.apache.org/language/index.html), along with
commit/rollback (do you have support for these yet in the thin dirver?). Also,
the ability to pass connection properties is important. Though our IT suite
could use some improvements, I wouldn't tangle that up with this JIRA.
Equally important is perf testing of the query server, but I suspect that'll
come after functional testing?
> Run all IT's through Query Server
> ---------------------------------
>
> Key: PHOENIX-1824
> URL: https://issues.apache.org/jira/browse/PHOENIX-1824
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 4.4.0
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Attachments: 1824.wip.patch
>
>
> Once we have PHOENIX-971 merged, we can increase our confidence in the server
> by parameterizing our IT suite to run over either driver, or both. This will
> probably require refactoring the IT suite out of phoenix-core/src/it into a
> separate module so that module can depend on both phoenix-core and
> phoenix-server modules.
> This is looking like it will also depend on improvements to Calcite that may
> not make it into 1.2 release (as RC's for that release have already started).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
