[
https://issues.apache.org/jira/browse/PHOENIX-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746435#comment-14746435
]
Josh Elser commented on PHOENIX-1824:
-------------------------------------
Thanks for the response, James. Super helpful.
bq. Super excited about your work
:humbly: thank you. Once I get this stuff merged into Calcite, keep an eye out
for some changes here to enable it. :)
bq. Things like indexing and salting are transparent to whether they came from
the thick or thin driver. Plus, some checks we do in some IT would be
problematic as they depend on state that wouldn't be available in a thin driver
client
Makes sense.
bq. I'd consider adding tests that try each statement type: SELECT, UPSERT
VALUES, UPSERT SELECT, DELETE, CREATE TABLE/VIEW/INDEX/SEQUENCE, DROP, ALTER
TABLE, etc, (see http://phoenix.apache.org/language/index.html),
Ok, that makes sense to me. I can
bq. Also, the ability to pass connection properties is important.
Any pointers to ones you would consider important? I see a bunch of properties
on the [tuning page|https://phoenix.apache.org/tuning.html].
bq. Though our IT suite could use some improvements, I wouldn't tangle that up
with this JIRA.
Noted. I don't want to be making huge, sweeping changes all over without
appropriate need.
bq. Equally important is perf testing of the query server, but I suspect
that'll come after functional testing?
Precisely. Going on the above, I'm much more concerned about an sufficient test
framework for correctness (had a decent shake-out period just dealing with
serialization/transformation stuff in Avatica). I want to have good confidence
for correctness to trust that will make all future work more easily done with
confidence.
> Run all IT's through Query Server
> ---------------------------------
>
> Key: PHOENIX-1824
> URL: https://issues.apache.org/jira/browse/PHOENIX-1824
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 4.4.0
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Attachments: 1824.wip.patch
>
>
> Once we have PHOENIX-971 merged, we can increase our confidence in the server
> by parameterizing our IT suite to run over either driver, or both. This will
> probably require refactoring the IT suite out of phoenix-core/src/it into a
> separate module so that module can depend on both phoenix-core and
> phoenix-server modules.
> This is looking like it will also depend on improvements to Calcite that may
> not make it into 1.2 release (as RC's for that release have already started).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
