[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004968#comment-15004968
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44849780
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java ---
@@ -223,23 +224,25 @@ public final ResultIterator iterator(final List<?
extends SQLCloseable> dependen
if (table.getType() != PTableType.SYSTEM) {
scan.setConsistency(connection.getConsistency());
}
- // Get the time range of row_timestamp column
- TimeRange rowTimestampRange =
context.getScanRanges().getRowTimestampRange();
- // Get the already existing time range on the scan.
- TimeRange scanTimeRange = scan.getTimeRange();
- Long scn = connection.getSCN();
- if (scn == null) {
- scn = context.getCurrentTime();
- }
- try {
- TimeRange timeRangeToUse =
ScanUtil.intersectTimeRange(rowTimestampRange, scanTimeRange, scn);
- if (timeRangeToUse == null) {
- return ResultIterator.EMPTY_ITERATOR;
- }
- scan.setTimeRange(timeRangeToUse.getMin(),
timeRangeToUse.getMax());
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ if (!table.isTransactional()) {
--- End diff --
I filed PHOENIX-2415, as we should support ROW_TIMESTAMP with transactional
tables (with some restrictions).
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
