[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005056#comment-15005056
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44852631
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -1386,7 +1430,7 @@ public MutationState 
createFunction(CreateFunctionStatement stmt) throws SQLExce
                     FunctionArgument arg = args.get(i);
                     addFunctionArgMutation(function.getFunctionName(), arg, 
argUpsert, i);
                 }
    -            
functionData.addAll(connection.getMutationState().toMutations().next().getSecond());
    +            
functionData.addAll(connection.getMutationState().toMutations(null).next().getSecond());
    --- End diff --
    
    This toMutations(null) looks a little funky. Maybe overload it so the null 
isn't required?


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to