[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005057#comment-15005057
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44852648
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -1498,30 +1542,61 @@ private PTable 
createTableInternal(CreateTableStatement statement, byte[][] spli
                 long clientTimeStamp = scn == null ? 
HConstants.LATEST_TIMESTAMP : scn;
                 boolean multiTenant = false;
                 boolean storeNulls = false;
    +            boolean transactional = false;
                 Integer saltBucketNum = null;
                 String defaultFamilyName = null;
                 boolean isImmutableRows = false;
                 List<PName> physicalNames = Collections.emptyList();
                 boolean addSaltColumn = false;
                 boolean rowKeyOrderOptimizable = true;
    +                   Long timestamp = null;
    --- End diff --
    
    Minor nit: check that your indenting is correct.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to