[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013004#comment-15013004
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/129#discussion_r45307183
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
 ---
    @@ -236,13 +239,14 @@ protected RegionScanner getWrappedScanner(final 
ObserverContext<RegionCoprocesso
          * re-throws as DoNotRetryIOException to prevent needless retrying 
hanging the query
          * for 30 seconds. Unfortunately, until HBASE-7481 gets fixed, there's 
no way to do
          * the same from a custom filter.
    -     * @param arrayFuncRefs
          * @param arrayKVRefs
    +     * @param arrayFuncRefs
          * @param offset starting position in the rowkey.
          * @param scan
          * @param tupleProjector
          * @param dataRegion
          * @param indexMaintainer
    +     * @param tx TODO
    --- End diff --
    
    Minor - remove TODO


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to