[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013036#comment-15013036
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307861
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -101,7 +105,7 @@ else if (SchemaUtil.isPKColumn(column)) {
public int hashCode() {
final int prime = 31;
int result = alias == null ? 0 : alias.hashCode();
- result = prime * result +
this.table.getName().getString().hashCode();
+ result = prime * result + ( this.table!=null &&
this.table.getName()!=null ? this.table.getName().getString().hashCode() : 0);
--- End diff --
Can the table in a TableRef be null? If not, then you probably don't need
the null check. If it cannot be null, then it would be also good to add
Preconditions.checkNotNull() checks in various constructors of this class. If
it can be null, then you also need to modify the equals method too (commented
below).
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
