[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013041#comment-15013041
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307979
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn, String table)
throws SQLException {
TAG_COUNT + " smallint, " +
ANNOTATION_COUNT + " smallint" +
" CONSTRAINT pk PRIMARY KEY (" + TRACE.columnName
+ ", "
- + PARENT.columnName + ", " + SPAN.columnName +
"))\n";
+ + PARENT.columnName + ", " + SPAN.columnName +
"))\n" +
+ PhoenixDatabaseMetaData.TRANSACTIONAL + "=" +
Boolean.FALSE;
--- End diff --
This is only for testing purposes. We have a config parameter that can be
set so that tables are transactional by default. If that's set, we still don't
want these system tables created as transactional tables, so we explicitly set
that to false.
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
