[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013859#comment-15013859
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/129#discussion_r45367376
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
    @@ -570,6 +946,97 @@ public void rollback(PhoenixConnection connection) 
throws SQLException {
         @Override
         public void close() throws SQLException {
         }
    +
    +    private void reset() {
    +        txStarted = false;
    +        tx = null;
    +        uncommittedPhysicalNames.clear();
    +    }
    +    
    +    public void rollback() throws SQLException {
    +        clear();
    +        txAwares.clear();
    +        if (txContext != null) {
    +            try {
    +                if (txStarted) {
    +                    txContext.abort();
    +                }
    +            } catch (TransactionFailureException e) {
    +                throw new SQLException(e); // TODO: error code
    --- End diff --
    
    New SQLExceptionCode here (same one as before).


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to