[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204515#comment-15204515 ]
Josh Mahonin commented on PHOENIX-2535: --------------------------------------- [~sergey.soldatov] Just tested this new patch with both Spark 1.6.0 and Spark 1.5.2. I ran a very small test that loaded a dataframe from a table, and saved it back to another table and can verify that it worked properly. Good work! A few more eyes on this to verify other use cases don't break at runtime (e.g. sqlline, standard JDBC, Storm, Flume, Pig, etc.) would be a good idea, but this looks good to me. Re: client-spark, it is no longer required with a properly shaded client JAR. It was a bit of a hack originally, so this patch helps make the documentation/deployment bits cleaner too. > Create shaded clients (thin + thick) > ------------------------------------- > > Key: PHOENIX-2535 > URL: https://issues.apache.org/jira/browse/PHOENIX-2535 > Project: Phoenix > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Sergey Soldatov > Fix For: 4.8.0 > > Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, > PHOENIX-2535-3.patch > > > Having shaded client artifacts helps greatly in minimizing the dependency > conflicts at the run time. We are seeing more of Phoenix JDBC client being > used in Storm topologies and other settings where guava versions become a > problem. > I think we can do a parallel artifact for the thick client with shaded > dependencies and also using shaded hbase. For thin client, maybe shading > should be the default since it is new? -- This message was sent by Atlassian JIRA (v6.3.4#6332)