[
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217711#comment-15217711
]
Sergey Soldatov commented on PHOENIX-2535:
------------------------------------------
[~enis] thank you for your review!
* patch reformatted
* changed shadowing pattern to org.apache.phoenix.shaded.com
* shadowed thrift, apache/directory, org/eclipse, unshadowed flume and tez,
htrace, commons/csv
* org/mortbay is used in log4j configuration, so I was afraid to shadow it
without knowing which kind of side effects it may cause
* sqlline is required for starting sqlline.py
* Only client is shadowing. Server part stays intact. The only difference that
for building it shadow plugin is using instead of assemble.
As for the plugin options that are using in hbase - most of them are related to
the case when there is a single artifact per module. In our case we creates
several artifacts and they are irrelevant.
> Create shaded clients (thin + thick)
> -------------------------------------
>
> Key: PHOENIX-2535
> URL: https://issues.apache.org/jira/browse/PHOENIX-2535
> Project: Phoenix
> Issue Type: Bug
> Reporter: Enis Soztutar
> Assignee: Sergey Soldatov
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch,
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency
> conflicts at the run time. We are seeing more of Phoenix JDBC client being
> used in Storm topologies and other settings where guava versions become a
> problem.
> I think we can do a parallel artifact for the thick client with shaded
> dependencies and also using shaded hbase. For thin client, maybe shading
> should be the default since it is new?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
