[ 
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218907#comment-15218907
 ] 

Josh Elser commented on PHOENIX-2535:
-------------------------------------

bq. If we are going with shaded client all the time, then maybe just do 
phoenix-client without shaded in the name. 

This makes sense to be, fwiw. I've looked at the phoenix-client jar as a 
standalone, consumable entity. Now, maybe I'm off base, but I think "shaded" is 
implied :)

bq. Do also shading in the phoenix-server-client module as well? wdyt Josh 
Elser? 

Would be good, but likely not nearly as high-priority as phoenix-client since 
there's not much more than an HTTP client in presently (maybe hadoop-common in 
the near future).

I'll try to make a moment to pull down Sergey's latest and poke at it locally 
too (dbl check service-loader files, etc).

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, 
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency 
> conflicts at the run time. We are seeing more of Phoenix JDBC client being 
> used in Storm topologies and other settings where guava versions become a 
> problem. 
> I think we can do a parallel artifact for the thick client with shaded 
> dependencies and also using shaded hbase. For thin client, maybe shading 
> should be the default since it is new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to