Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57341237
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java ---
@@ -94,6 +99,8 @@ public void testCreateTable() throws Exception {
" id INTEGER not null primary key desc\n" +
" ) ";
conn.createStatement().execute(ddl);
+ HBaseAdmin admin = driver.getConnectionQueryServices(getUrl(),
props).getAdmin();
+ assertNotEquals(null,
admin.getTableDescriptor(Bytes.toBytes(tableName)));
--- End diff --
Minor nits: assertNotNull reads better here. Same recommendations as above
regarding getting and closing HBaseAdmin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
