Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57363423
--- Diff: phoenix-protocol/src/main/MetaDataService.proto ---
@@ -72,6 +79,12 @@ message GetFunctionsRequest {
optional int32 clientVersion = 5;
}
+message GetSchemaRequest {
+ required string schemaName = 1;
+ required int64 clientTimestamp = 2;
+ optional int32 clientVersion = 3;
--- End diff --
Should the client version be optional or required? Considering this is a
new metadata entity, I would think most of the things here should have
"required" unless of course functionally they don't have to be present always.
This applies to all the other schema related requests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
