Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r57364562
  
    --- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java 
---
    @@ -825,9 +825,27 @@ protected static void ensureTableCreated(String url, 
String tableName, Long ts)
     
         protected static void ensureTableCreated(String url, String tableName, 
byte[][] splits, Long ts) throws SQLException {
             String ddl = tableDDLMap.get(tableName);
    +        createSchema(url,tableName, ts);
             createTestTable(url, ddl, splits, ts);
         }
     
    +    public static void createSchema(String url, String tableName, Long ts) 
throws SQLException {
    +        if (tableName.contains(".")) {
    +            String schema = tableName.substring(0, tableName.indexOf("."));
    +            if (!schema.equals("")) {
    +                Properties props = new Properties();
    +                if (ts != null) {
    +                    props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB, 
Long.toString(ts));
    +                }
    +                try (Connection conn = DriverManager.getConnection(url, 
props);) {
    +                    conn.createStatement().executeUpdate("CREATE SCHEMA IF 
NOT EXISTS " + schema);
    +                } catch (TableAlreadyExistsException e) {
    --- End diff --
    
    Remove the catch() block here as it doesn't apply.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to