[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214607#comment-15214607
]
ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57608384
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java
---
@@ -74,7 +74,7 @@ public
ChunkedResultIteratorFactory(ParallelIteratorFactory
@Override
public PeekingResultIterator newIterator(StatementContext context,
ResultIterator scanner, Scan scan, String tableName) throws SQLException {
- if (logger.isDebugEnabled())
logger.debug(LogUtil.addCustomAnnotations("ChunkedResultIteratorFactory.newIterator
over " + tableRef.getTable().getName().getString() + " with " + scan,
ScanUtil.getCustomAnnotations(scan)));
+ if (logger.isDebugEnabled())
logger.debug(LogUtil.addCustomAnnotations("ChunkedResultIteratorFactory.newIterator
over " + tableRef.getTable().getPhysicalName().getString() + " with " + scan,
ScanUtil.getCustomAnnotations(scan)));
--- End diff --
I changed it as there is a reference to scan so I thought, physical names
in the logs would be required for better debugging. let me know if you think we
should keep phoenix names in **logging** as it is.
> HBase namespaces surfaced in phoenix
> ------------------------------------
>
> Key: PHOENIX-1311
> URL: https://issues.apache.org/jira/browse/PHOENIX-1311
> Project: Phoenix
> Issue Type: New Feature
> Reporter: nicolas maillard
> Assignee: Ankit Singhal
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch,
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
