[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214618#comment-15214618
 ] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r57609323
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
    @@ -120,7 +120,7 @@ protected void explain(String prefix, List<String> 
planSteps) {
             } else {
                 explainSkipScan(buf);
             }
    -        buf.append("OVER 
").append(tableRef.getTable().getPhysicalName().getString());
    +        buf.append("OVER 
").append(tableRef.getTable().getPhoenixPhysicalName().getString());
    --- End diff --
    
    getPhoenixPhysicalName() is required to get phoenix table name (X.Y) , this 
is different from getName() as in case of view, it return phoenix name of the 
data table ,which sometimes required for "Explain" plan or sometimes to get 
tableRef for data table. I think , we can have different name for this method 
to avoid confusion.
    
    getPhysicalName gives the hbase representation(X:Y) of table/view depending 
upon isNamespaceMapped flag.


> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to