[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225545#comment-15225545
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58479273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -165,7 +183,7 @@ public RegionScanner preScannerOpen(final
ObserverContext<RegionCoprocessorEnvir
scan.setTimeRange(timeRange.getMin(), Bytes.toLong(txnScn));
}
if (isRegionObserverFor(scan)) {
- if (! skipRegionBoundaryCheck(scan)) {
+ if (! skipRegionBoundaryCheck(scan) ||
ScanUtil.isLocalIndex(scan)) {
--- End diff --
Add comment, please. Something like this:
// For local indexes, we need to throw if out of region as we'll get
duplicates otherwise while in other cases,
// it may just mean out client-side data on region boundaries is out of
date and can safely be ignored.
Note that we'll need to handle this from the MR integration which might be
painful.
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
