[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225621#comment-15225621
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483157
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java ---
@@ -209,7 +209,11 @@ protected ResultIterator
newIterator(ParallelScanGrouper scanGrouper) throws SQL
if (isOrdered) {
scanner = new MergeSortTopNResultIterator(iterators, limit,
orderBy.getOrderByExpressions());
} else {
- if ((isSalted || table.getIndexType() == IndexType.LOCAL) &&
ScanUtil.shouldRowsBeInRowKeyOrder(orderBy, context)) {
+ if ((isSalted || table.getIndexType() == IndexType.LOCAL)
+ && ScanUtil.shouldRowsBeInRowKeyOrder(orderBy, context)
+ || (table.getIndexType() == IndexType.LOCAL &&
(Bytes.compareTo(
+ scan.getStartRow(),
this.context.getScan().getStartRow()) != 0 || Bytes
+ .compareTo(scan.getStopRow(),
this.context.getScan().getStopRow()) != 0))) {
--- End diff --
Why is a merge sort required for this new condition? Is this the case when
the original start/stop row has changed? Is this purely for the chunked result
iterator case? Let's document this and add a TODO to remove as the chunked
result iterator is deprecated (and if you could consistently add this TODO for
other parts of code only necessary due to this deprecated chunking mechanism,
that'd be much appreciated).
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
