[ 
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235684#comment-15235684
 ] 

Josh Elser commented on PHOENIX-2535:
-------------------------------------

Made a quick list of all non-relocated classes in the phoenix-client jar:

{noformat}
co/cask/tephra
javax
org/apache/commons/logging
org/eclipse/jetty
org/apache/calcite/avatica/proto
org/apache/hadoop
com/sun/jersey
org/apache/pig
org/apache/flume
contribs/mx/
com/sun/xml
com/sun/appserv
com/sun/el
org/mortbay
javax/ws/rs
org/apache/hadoop/hbase
org/apache/htrace
com/google/common
edu/umd/cs/findbugs
org/objectweb/asm
{noformat}

I know some of these [~enis] already pointed out (mortbay, specifically), but 
com.google.common, pig/flume/hadoop/hbase, asm, and jersey worry me. Is there a 
reason these aren't relocated? Sorry if I missed back-chat.

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, 
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency 
> conflicts at the run time. We are seeing more of Phoenix JDBC client being 
> used in Storm topologies and other settings where guava versions become a 
> problem. 
> I think we can do a parallel artifact for the thick client with shaded 
> dependencies and also using shaded hbase. For thin client, maybe shading 
> should be the default since it is new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to