[ 
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235776#comment-15235776
 ] 

Josh Elser commented on PHOENIX-2535:
-------------------------------------

bq. No, I'm talking about how we run query server. For sandbox we take 
-runnable.jar from the server package, but when we run it from tarball we run 
it with the regular phoenix-client jar. That's why we have phoenix-client 
depended on phoenix-server (phoenix-queryserver now). 

Ok, I see what you mean now. The phoenix-server-$VERSION-runnable.jar is no 
longer used when invoking {{queryserver.py}}. This doesn't make sense to me. 
Clients shouldn't be seeing any of the PQS implementation. We have a clear 
delineation there now, and I think we should keep that.

{noformat}
$ ./bin/queryserver.py
/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/bin/java -cp 
/usr/local/lib/hbase/conf:/usr/local/lib/hadoop/etc/hadoop::/usr/local/lib/phoenix-4.8.0-HBase-1.1-SNAPSHOT-shaded/bin/../phoenix-4.8.0-HBase-1.1-SNAPSHOT-client.jar
 -Dproc_phoenixserver 
-Dlog4j.configuration=file:/usr/local/lib/phoenix-4.8.0-HBase-1.1-SNAPSHOT-shaded/bin/log4j.properties
 -Dpsql.root.logger=INFO,console -Dpsql.log.dir=. -Dpsql.log.file=psql.log  
org.apache.phoenix.queryserver.server.Main
{noformat}

I see that the old phoenix-server-$VERSION-runnable.jar is still being created 
but it not longer exists in the tarball's lib/ directory.

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, 
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency 
> conflicts at the run time. We are seeing more of Phoenix JDBC client being 
> used in Storm topologies and other settings where guava versions become a 
> problem. 
> I think we can do a parallel artifact for the thick client with shaded 
> dependencies and also using shaded hbase. For thin client, maybe shading 
> should be the default since it is new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to