[ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415862#comment-15415862
 ] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74313800
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseScanIT.java ---
    @@ -52,11 +52,11 @@
     import com.google.common.collect.Maps;
     
     
    -public class ReverseScanIT extends BaseHBaseManagedTimeIT {
    -    protected static final String ATABLE_INDEX_NAME = "ATABLE_IDX";
    +public class ReverseScanIT extends BaseHBaseManagedTimeTableReuseIT {
    +    protected static final String ATABLE_INDEX_NAME = 
generateRandomString();
     
         @BeforeClass
    -    @Shadower(classBeingShadowed = BaseHBaseManagedTimeIT.class)
    +    @Shadower(classBeingShadowed = BaseHBaseManagedTimeTableReuseIT.class)
    --- End diff --
    
    I think you can remove the doSetup() method altogether here. We don't need 
to disable and delete ATABLE_NAME any more.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to