[ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415832#comment-15415832
 ] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74312230
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java ---
    @@ -95,53 +96,62 @@ private static Filter getUserTableAndViewsFilter() {
         }
         
         private void testGetTenantIdExpression(boolean isSalted) throws 
Exception {
    +        //Have to metaData tables because BaseHBaseManagedTimeTableReuseIT 
doesn't delete them after each test case , and tenant list will create issues 
between test cases
    +        deletePriorMetaData(HConstants.LATEST_TIMESTAMP, getUrl());
    --- End diff --
    
    Do we need this if we randomly generate the tenantIds? 


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to