[ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415817#comment-15415817
 ] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74311348
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/LnLogFunctionEnd2EndIT.java 
---
    @@ -33,10 +33,12 @@
     /**
      * End to end tests for {@link LnFunction} and {@link LogFunction}
      */
    -public class LnLogFunctionEnd2EndIT extends BaseHBaseManagedTimeIT {
    +public class LnLogFunctionEnd2EndIT extends 
BaseHBaseManagedTimeTableReuseIT {
     
         private static final String KEY = "key";
         private static final double ZERO = 1e-9;
    +    private String signedTableName;
    --- End diff --
    
    No member variables for storing table names, please.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to