[
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533602#comment-15533602
]
ASF GitHub Bot commented on PHOENIX-3264:
-----------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81201783
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call) {
return null;
}
}
+
+ public static Object convertLiteral(SqlLiteral literal,
PhoenixRelImplementor implementor) {
+ try {
+ final SchemaPlus rootSchema =
Frameworks.createRootSchema(true);
+ final FrameworkConfig config = Frameworks.newConfigBuilder()
+ .parserConfig(SqlParser.Config.DEFAULT)
+ .defaultSchema(rootSchema).build();
+ Planner planner = Frameworks.getPlanner(config);
+
+ SqlParserPos POS = SqlParserPos.ZERO;
+ final SqlNodeList selectList =
+ new SqlNodeList(
+ Collections.singletonList(literal),
+ SqlParserPos.ZERO);
+
+
+ String sql = new SqlSelect(POS, SqlNodeList.EMPTY, selectList,
null, null, null, null,
+ SqlNodeList.EMPTY, null, null, null).toString();
+ SqlNode sqlNode = planner.parse(sql);
+ sqlNode = planner.validate(sqlNode);
+ Project proj = (Project) (planner.rel(sqlNode).rel);
--- End diff --
Probably better to add an "assert" here to ensure the rel object is of
Project class before casting it. Similarly, assert that this Project has only
one expression for the following statement.
> Allow TRUE and FALSE to be used as literal constants
> ----------------------------------------------------
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Eric Lomore
> Attachments: Sql2RelImplementation.png, SqlLiteral.png,
> SqlNodeToRexConverterImpl.png, SqlOptionNode.png, objectdependencies.png,
> objectdependencies2.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite
> doesn't? Looks like this is leading to a fair number of failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
