Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/242#discussion_r116866567
--- Diff:
phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/QueryServerBasicsIT.java
---
@@ -161,5 +196,45 @@ public void smokeTest() throws Exception {
}
}
}
+ assertTrue(" metrics file should contain global ",
+ checkFileContainsMetricsData(global));
+ assertTrue(" metrics file should contain overall statement level
metrics",
+ checkFileContainsMetricsData(overAllReadRequestMetrics));
+ assertTrue(" metrics file should contain statement level read metrics",
+ checkFileContainsMetricsData(requestReadMetrics));
+ assertTrue(" metrics file should contain connection level write
metrics",
+ checkFileContainsMetricsData(writeMetricsMut));
+ }
+
+ private static boolean checkFileContainsMetricsData(String metricsType)
throws Exception {
+ FileReader fileReader = new FileReader(pqsSinkFile);
+ try(BufferedReader br = new BufferedReader(fileReader)) {
+ String st;
+ while (( st = br.readLine() ) != null) {
+ ObjectMapper mapper = new ObjectMapper();
+ JsonNode actualObj = mapper.readTree(st);
+ boolean contains = actualObj.get(metricsType)!= null?true:false;
+ if (contains) {
+ return true; // the outputfile does contain metrics jsons
+ }
+ }
+ };
+ return false;
}
+
+ public static Thread getThreadByName(String threadName) {
+ for (Thread t : Thread.getAllStackTraces().keySet()) {
+ if (t.getName().equals(threadName)) return t;
+ }
+ return null;
+ }
+
+ private static void stopGlobalThread(){
+ //need to stop the global metrics thread
+ Thread globalMetricsThread = getThreadByName("globalMetricsThread");
--- End diff --
This is pretty hokey -- I think you should encapsulate the state of
stopping this thread in PqsMetricsSystem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
