Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/242#discussion_r116865709
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/metrics/PqsMetricsSystem.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.queryserver.metrics;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.phoenix.query.QueryServicesOptions;
+import org.apache.phoenix.queryserver.metrics.sink.PqsFileSink;
+import org.apache.phoenix.queryserver.metrics.sink.PqsSink;
+import org.apache.phoenix.queryserver.metrics.sink.PqsSlf4jSink;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.phoenix.query.QueryServices.PHOENIX_PQS_FILE_SINK_FILENAME;
+import static
org.apache.phoenix.query.QueryServices.PHOENIX_PQS_METRIC_REPORTING_INTERVAL_MS;
+import static
org.apache.phoenix.query.QueryServices.PHOENIX_PQS_TYPE_OF_SINK;
+
+
+public class PqsMetricsSystem {
+
+ public final static String statementReadMetrics =
"Statement-RequestReadMetrics";
+ public final static String overAllReadRequestMetrics =
"Statement-OverAllReadRequestMetrics";
+ public final static String connectionWriteMetricsForMutations =
"Connection-WriteMetricsForMutations";
+ public final static String connectionReadMetricsForMutations =
"Connection-ReadMetricsForMutations";
+
+ public enum MetricType {
+ global,
+ request
+ }
+
+ protected static final Logger LOG =
LoggerFactory.getLogger(PqsMetricsSystem.class);
+
+ public Thread getGlobalMetricThread() {
+ return globalMetricThread;
+ }
+
+ private Thread globalMetricThread = null;
+
+
+ public PqsMetricsSystem(String sinkType,String fileName, Integer
reportingInterval){
+ PqsGlobalMetrics pqsGlobalMetricsToJMX = null;
+ try {
+ pqsGlobalMetricsToJMX = new PqsGlobalMetrics(sinkType,
fileName,reportingInterval);
+ globalMetricThread = new Thread(pqsGlobalMetricsToJMX);
--- End diff --
IMO, it would be much nicer to use a `ExecutorService` to manage this
instead of the thread directly.
This is missing an UncaughtExceptionHandler. If the metrics thread dies for
some reason, it would go unnoticed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
