Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/242#discussion_r116868081
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/PhoenixMetaFactoryImpl.java
---
@@ -68,7 +73,18 @@ public Meta create(List<String> args) {
"0 or 1 argument expected. Received " +
Arrays.toString(args.toArray()));
}
// TODO: what about -D configs passed in from cli? How do they get
pushed down?
- return new JdbcMeta(url, info);
+ boolean isMetricOn = conf.getBoolean(PHOENIX_QUERY_SERVER_METRICS,
+ DEFAULT_PHOENIX_QUERY_SERVER_METRICS);
+ if (isMetricOn) {
+ info.put("pqs_reporting_interval",
PqsMetricsSystem.getReportingInterval(conf));
--- End diff --
Why this indirection with pqs_reporting_interval to
phoenix.query.server.metrics.report.interval.ms internally? Just use our
configuration properties all around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
