[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013186#comment-16013186
]
ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/242#discussion_r116866567
--- Diff:
phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/QueryServerBasicsIT.java
---
@@ -161,5 +196,45 @@ public void smokeTest() throws Exception {
}
}
}
+ assertTrue(" metrics file should contain global ",
+ checkFileContainsMetricsData(global));
+ assertTrue(" metrics file should contain overall statement level
metrics",
+ checkFileContainsMetricsData(overAllReadRequestMetrics));
+ assertTrue(" metrics file should contain statement level read metrics",
+ checkFileContainsMetricsData(requestReadMetrics));
+ assertTrue(" metrics file should contain connection level write
metrics",
+ checkFileContainsMetricsData(writeMetricsMut));
+ }
+
+ private static boolean checkFileContainsMetricsData(String metricsType)
throws Exception {
+ FileReader fileReader = new FileReader(pqsSinkFile);
+ try(BufferedReader br = new BufferedReader(fileReader)) {
+ String st;
+ while (( st = br.readLine() ) != null) {
+ ObjectMapper mapper = new ObjectMapper();
+ JsonNode actualObj = mapper.readTree(st);
+ boolean contains = actualObj.get(metricsType)!= null?true:false;
+ if (contains) {
+ return true; // the outputfile does contain metrics jsons
+ }
+ }
+ };
+ return false;
}
+
+ public static Thread getThreadByName(String threadName) {
+ for (Thread t : Thread.getAllStackTraces().keySet()) {
+ if (t.getName().equals(threadName)) return t;
+ }
+ return null;
+ }
+
+ private static void stopGlobalThread(){
+ //need to stop the global metrics thread
+ Thread globalMetricsThread = getThreadByName("globalMetricsThread");
--- End diff --
This is pretty hokey -- I think you should encapsulate the state of
stopping this thread in PqsMetricsSystem
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Rahul Shrivastava
> Fix For: 4.9.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
