[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013404#comment-16013404
]
ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------
Github user rahulsIOT commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/242#discussion_r116896889
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -272,6 +278,11 @@
public static final String DEFAULT_IMMUTABLE_STORAGE_SCHEME =
ImmutableStorageScheme.SINGLE_CELL_ARRAY_WITH_OFFSETS.toString();
public static final String
DEFAULT_MULTITENANT_IMMUTABLE_STORAGE_SCHEME =
ImmutableStorageScheme.ONE_CELL_PER_COLUMN.toString();
+ public static final Integer DEFAULT_PHOENIX_PQS_REPORTING_INTERVAL_MS
= 10000; // 10 sec
+ public static final String DEFAULT_PHOENIX_PQS_TYPE_OF_SINK = "file";
+ public static final boolean DEFAULT_PHOENIX_QUERY_SERVER_METRICS =
true;
--- End diff --
made the metrics collection to be off by default.
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Rahul Shrivastava
> Fix For: 4.9.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
