Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/277#discussion_r146662118
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -2905,14 +2918,18 @@ public void upgradeSystemTables(final String url, 
final Properties props) throws
                         }
                     } finally {
                         if (acquiredMutexLock) {
    -                        releaseUpgradeMutex(mutexRowKey);
    +                        try {
    +                            releaseUpgradeMutex(mutexRowKey);
    +                        } catch (IOException e) {
    +                            logger.warn("Release of upgrade mutex failed 
", e);
    --- End diff --
    
    Is it ok to continue on if we fail to release the upgrade mutex, or should 
we just let the exception be thrown?


---

Reply via email to