Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/277#discussion_r146695798
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -2905,14 +2918,18 @@ public void upgradeSystemTables(final String url, 
final Properties props) throws
                         }
                     } finally {
                         if (acquiredMutexLock) {
    -                        releaseUpgradeMutex(mutexRowKey);
    +                        try {
    +                            releaseUpgradeMutex(mutexRowKey);
    +                        } catch (IOException e) {
    +                            logger.warn("Release of upgrade mutex failed 
", e);
    --- End diff --
    
    I think it is fine not to throw the exception because we have a TTL on the 
table. Typically it should not matter to the client as such. Moreover, similar 
behavior is also defined the code that Upgrades the SYSCAT table. 


---

Reply via email to