[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

[joshelser]

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/277#discussion_r146904748
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -3195,6 +3255,18 @@ public boolean releaseUpgradeMutex(byte[] 
mutexRowKey) {
             return released;
         }
     
    +    private byte[] getSysMutexPhysicalTableNameBytes() throws IOException, 
SQLException {
    +        byte[] sysMutexPhysicalTableNameBytes = null;
    +        try(HBaseAdmin admin = getAdmin()) {
    +            
if(admin.tableExists(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME_BYTES)) {
    --- End diff --
    
    I assume `PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME_BYTES` is `byte[]`? 
Would be better to use the `TableName` variable to avoid deprecated API warning.


---