> On 2011-01-14 15:46:50, Richard Ding wrote: > > I downloaded the patch. It gives some compilation errors such as "package > > sun.org.mozilla.javascript.internal does not exist". Is there some jars > > missing from compile classpath?
It uses the Rhino bundled in the JDK. Hence the sun.org.mozilla... It would probably be better to use the standard Rhino. Maybe you don't use the same version of the JDK ? - Julien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/321/#review124 ----------------------------------------------------------- On 2011-01-13 19:01:24, Julien Le Dem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/321/ > ----------------------------------------------------------- > > (Updated 2011-01-13 19:01:24) > > > Review request for pig and Richard Ding. > > > Summary > ------- > > This is not a final patch. > I've limited modifications to the existing framework as much as possible. > However some changes where necessary. They are backward compatible. > > > This addresses bug PIG-1794. > https://issues.apache.org/jira/browse/PIG-1794 > > > Diffs > ----- > > /trunk/src/org/apache/pig/Main.java 1056815 > /trunk/src/org/apache/pig/scripting/Pig.java 1056815 > /trunk/src/org/apache/pig/scripting/ScriptEngine.java 1056815 > /trunk/src/org/apache/pig/scripting/ScriptPigContext.java 1056815 > /trunk/src/org/apache/pig/scripting/js/JsFunction.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/js/JsScriptEngine.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/js/Pig.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java 1056815 > /trunk/test/org/apache/pig/test/TestScriptLanguageJavaScript.java > PRE-CREATION > /trunk/test/org/apache/pig/test/data/tc.js PRE-CREATION > > Diff: https://reviews.apache.org/r/321/diff > > > Testing > ------- > > > Thanks, > > Julien > >
