> On 2011-01-14 15:49:04, Dmitriy Ryaboy wrote: > > Minor tweaks below. > > Needs the ant/ivy work. > > Should probably be integrated in such a way that only a specific ant target > > builds js support and bundles Rhino; we shouldn't pack everything in by > > default.
It uses the Rhino bundled in the JDK. Hence the sun.org.mozilla... which is not ideal. I'll convert to an official Rhino distrib. my comments inline. (when none, it means I do not feel strongly about it) - Julien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/321/#review118 ----------------------------------------------------------- On 2011-01-13 19:01:24, Julien Le Dem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/321/ > ----------------------------------------------------------- > > (Updated 2011-01-13 19:01:24) > > > Review request for pig and Richard Ding. > > > Summary > ------- > > This is not a final patch. > I've limited modifications to the existing framework as much as possible. > However some changes where necessary. They are backward compatible. > > > This addresses bug PIG-1794. > https://issues.apache.org/jira/browse/PIG-1794 > > > Diffs > ----- > > /trunk/src/org/apache/pig/Main.java 1056815 > /trunk/src/org/apache/pig/scripting/Pig.java 1056815 > /trunk/src/org/apache/pig/scripting/ScriptEngine.java 1056815 > /trunk/src/org/apache/pig/scripting/ScriptPigContext.java 1056815 > /trunk/src/org/apache/pig/scripting/js/JsFunction.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/js/JsScriptEngine.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/js/Pig.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java 1056815 > /trunk/test/org/apache/pig/test/TestScriptLanguageJavaScript.java > PRE-CREATION > /trunk/test/org/apache/pig/test/data/tc.js PRE-CREATION > > Diff: https://reviews.apache.org/r/321/diff > > > Testing > ------- > > > Thanks, > > Julien > >
