----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/321/ -----------------------------------------------------------
(Updated 2011-01-16 22:40:06.285242) Review request for pig and Richard Ding. Changes ------- I have updated the code based on the comments (some I have not done yet but planning to): - switched to official Rhino (not sure how to make it optional) - used StringBuffer more - moved the list of languages out of Main - factored the script loading - added comments - added namespace for functions Summary ------- This is not a final patch. I've limited modifications to the existing framework as much as possible. However some changes where necessary. They are backward compatible. This addresses bug PIG-1794. https://issues.apache.org/jira/browse/PIG-1794 Diffs (updated) ----- /trunk/ivy.xml 1056815 /trunk/ivy/libraries.properties 1056815 /trunk/ivy/pig.pom 1056815 /trunk/src/org/apache/pig/Main.java 1056815 /trunk/src/org/apache/pig/scripting/Pig.java 1056815 /trunk/src/org/apache/pig/scripting/ScriptEngine.java 1056815 /trunk/src/org/apache/pig/scripting/ScriptPigContext.java 1056815 /trunk/src/org/apache/pig/scripting/js/JsFunction.java PRE-CREATION /trunk/src/org/apache/pig/scripting/js/JsScriptEngine.java PRE-CREATION /trunk/src/org/apache/pig/scripting/js/Pig.java PRE-CREATION /trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java 1056815 /trunk/test/org/apache/pig/test/TestScriptLanguageJavaScript.java PRE-CREATION /trunk/test/org/apache/pig/test/data/tc.js PRE-CREATION Diff: https://reviews.apache.org/r/321/diff Testing ------- Thanks, Julien