[
https://issues.apache.org/jira/browse/PIG-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487019#comment-13487019
]
Cheolsoo Park commented on PIG-2881:
------------------------------------
Hi Joel,
That looks good. Thank you very much for fixing the tests! I assume that you
would fix TestStore.java as well?
One minor comments:
- Please change the assertEquals to the following:
{code}
assertEquals(expected, p.replaceAll(protocol + "://" + regex + "*/", "/"));
{code}
- I noticed that you used 2 spaces to indent code for your original patch.
Please use 4 spaces.
I will review and commit it when you upload your patch.
> Add SUBTRACT eval function
> --------------------------
>
> Key: PIG-2881
> URL: https://issues.apache.org/jira/browse/PIG-2881
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
> Affects Versions: 0.10.0
> Reporter: Joel Costigliola
> Priority: Minor
> Attachments: Subtract.java, SubtractTest.java,
> TEST-org.apache.pig.test.TestLoad.txt, TEST-org.apache.pig.test.TestStore.txt
>
>
> Close to DIFF function but SUBTRACT(bag1, bag2) will subtract elements of
> bag2 from bag1.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
