[
https://issues.apache.org/jira/browse/PIG-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487395#comment-13487395
]
Cheolsoo Park commented on PIG-2881:
------------------------------------
Hi Joel,
OK, I asked that on the dev list. We should keep the test as a separate file,
but we should change its location and change its name.
- Please move the test to {{o.a.pig.builtin.test}}
- Please change the name to {{TestSUBTRACT.java}}.
I saw your comment regarding the test name, but if we move it to
{{o.a.pig.builtin.test}}, we won't have a confusion since the other
{{TestSubtract.java}} is under {{o.a.pig.test}}. Agreed?
Here are few other minor comments:
1) There is a typo in your patch.
{code:title=TestSUBTRACTFunc.java}
import static org.junit.Assert.assertTrueS; // 'S' should be removed.
{code}
2) The following import statement is not used. Please remove:
{code:title=TestSUBTRACTFunc.java}
import org.junit.Assert;
{code}
3) Please update the doc. Please look for the 'Eval Function' section in
{{src/docs/src/documentation/content/xdocs/func.xml}}. To build it, run:
{code}
ant docs -Dforrest.home=<FORREST_HOME>
{code}
This will generate {{./src/docs/build/site/func.html}}.
4) Lastly, it would be better if you could re-name each test case as
"testBlah". I won't insist on this, so you can leave them as they are if you
want to.
Thanks!
> Add SUBTRACT eval function
> --------------------------
>
> Key: PIG-2881
> URL: https://issues.apache.org/jira/browse/PIG-2881
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
> Affects Versions: 0.10.0
> Reporter: Joel Costigliola
> Priority: Minor
> Attachments: PIG-2881.patch, Subtract.java, SubtractTest.java,
> TEST-org.apache.pig.test.TestLoad.txt, TEST-org.apache.pig.test.TestStore.txt
>
>
> Close to DIFF function but SUBTRACT(bag1, bag2) will subtract elements of
> bag2 from bag1.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
