[
https://issues.apache.org/jira/browse/PIG-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487241#comment-13487241
]
Cheolsoo Park commented on PIG-2881:
------------------------------------
Hi Joel,
Thanks for uploading the patch. It looks really good. Two minor comments:
- Can you please use Unix style newline chars?
- Can you please remove trailing white spaces?
I am not supposed to modify your patch in any way, so please forgive me for
asking you do extra work.
A bigger question that I had was whether we should create a new suite
(TestSUBTRACTFunc) or add new test cases to the existing TestBuiltin suite.
Given that TestBuiltin is near 3k line long, I like to break this test suite
into smaller pieces and make your patch be the 1st step toward that goal. But I
need to know what other people think. I probably ask it on the dev mailing
list. Please feel free to provide your opinion.
Thanks!
> Add SUBTRACT eval function
> --------------------------
>
> Key: PIG-2881
> URL: https://issues.apache.org/jira/browse/PIG-2881
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
> Affects Versions: 0.10.0
> Reporter: Joel Costigliola
> Priority: Minor
> Attachments: PIG-2881.patch, Subtract.java, SubtractTest.java,
> TEST-org.apache.pig.test.TestLoad.txt, TEST-org.apache.pig.test.TestStore.txt
>
>
> Close to DIFF function but SUBTRACT(bag1, bag2) will subtract elements of
> bag2 from bag1.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
