mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows
compatibility of a batch of pinot-core tests
URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r255603424
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/startree/v2/BaseStarTreeV2Test.java
##########
@@ -141,7 +141,9 @@ public void setUp()
// Randomly build star-tree using on-heap or off-heap mode
BuildMode buildMode = RANDOM.nextBoolean() ? BuildMode.ON_HEAP :
BuildMode.OFF_HEAP;
- new
MultipleTreesBuilder(Collections.singletonList(starTreeV2BuilderConfig),
indexDir, buildMode).build();
+ MultipleTreesBuilder builder = new
MultipleTreesBuilder(Collections.singletonList(starTreeV2BuilderConfig),
indexDir, buildMode);
+ builder.build();
+ builder.close();
Review comment:
MultipleTreesBuilder is not a closeable, so I am not sure why we need to
call close here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
