mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows
compatibility of a batch of pinot-core tests
URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r256056443
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/startree/v2/BaseStarTreeV2Test.java
##########
@@ -141,7 +141,9 @@ public void setUp()
// Randomly build star-tree using on-heap or off-heap mode
BuildMode buildMode = RANDOM.nextBoolean() ? BuildMode.ON_HEAP :
BuildMode.OFF_HEAP;
- new
MultipleTreesBuilder(Collections.singletonList(starTreeV2BuilderConfig),
indexDir, buildMode).build();
+ MultipleTreesBuilder builder = new
MultipleTreesBuilder(Collections.singletonList(starTreeV2BuilderConfig),
indexDir, buildMode);
+ builder.build();
+ builder.close();
Review comment:
Can you post the failure message? What does it complain about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
