mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows 
compatibility of a batch of pinot-core tests
URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r255600970
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
 ##########
 @@ -133,4 +133,8 @@ private static SingleTreeBuilder 
getSingleTreeBuilder(StarTreeV2BuilderConfig bu
       return new OffHeapSingleTreeBuilder(builderConfig, outputDir, segment, 
metadataProperties);
     }
   }
+
+  public void close() {
 
 Review comment:
   I have the same question as @sunithabeeram on this one. Where is this being 
called?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

Reply via email to