[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300581#comment-17300581
]
Roger Lee Whitcomb commented on PIVOT-1032:
-------------------------------------------
Changes to eliminate checkstyle violations in the non-wtk Listener classes.
Sending charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java
Sending charts/src/org/apache/pivot/charts/ChartViewListener.java
Sending charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java
Sending core/src/org/apache/pivot/collections/ListListener.java
Sending core/src/org/apache/pivot/collections/MapListener.java
Sending core/src/org/apache/pivot/collections/QueueListener.java
Sending core/src/org/apache/pivot/collections/SetListener.java
Sending core/src/org/apache/pivot/collections/StackListener.java
Sending core/src/org/apache/pivot/json/JSONSerializerListener.java
Sending core/src/org/apache/pivot/util/MessageBusListener.java
Sending core/src/org/apache/pivot/xml/ElementListener.java
Sending core/src/org/apache/pivot/xml/NodeListener.java
Sending core/src/org/apache/pivot/xml/XMLSerializerListener.java
Sending
tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java
Sending
tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java
Sending
tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java
Sending web/src/org/apache/pivot/web/QueryListener.java
Transmitting file data .................done
Committing transaction...
Committed revision 1887549.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Lee Whitcomb
> Assignee: Roger Lee Whitcomb
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
