[ 
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134957#comment-17134957
 ] 

Roger Lee Whitcomb commented on PIVOT-1032:
-------------------------------------------

A variety of fixes (mostly files with one or two problems):
Sending        charts/src/org/apache/pivot/charts/Provider.java
Sending        core/src/org/apache/pivot/annotations/UnsupportedOperation.java
Adding         core/src/org/apache/pivot/annotations/package.html
Sending        core/src/org/apache/pivot/functional/monad/Monad.java
Sending        core/src/org/apache/pivot/functional/monad/MonadicOperations.java
Sending        
core/src/org/apache/pivot/serialization/CSVSerializerListener.java
Sending        core/src/org/apache/pivot/util/ClassUtils.java
Sending        core/src/org/apache/pivot/util/concurrent/TaskListener.java
Sending        core/test/org/apache/pivot/util/test/MIMETypeTest.java
Sending        demos/src/org/apache/pivot/demos/text/TextPaneDemo.java
Sending        tests/src/org/apache/pivot/tests/EnumBean.java
Sending        tests/src/org/apache/pivot/tests/TextAreaConsoleTest.java
Sending        web/src/org/apache/pivot/web/Authentication.java
Sending        web/src/org/apache/pivot/web/Query.java
Sending        web/src/org/apache/pivot/web/QueryListener.java
Sending        
wtk/src/org/apache/pivot/wtk/ColorChooserButtonSelectionListener.java
Sending        wtk/src/org/apache/pivot/wtk/Component.java
Sending        wtk/src/org/apache/pivot/wtk/FocusTraversalDirection.java
Sending        wtk/src/org/apache/pivot/wtk/SortDirection.java
Sending        wtk/src/org/apache/pivot/wtk/skin/VFSBrowserSkin.java
Transmitting file data ....................done
Committing transaction...
Committed revision 1878815.


> Implement "checkstyle" for builds and make changes to bring code into better 
> compliance
> ---------------------------------------------------------------------------------------
>
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Lee Whitcomb
>            Assignee: Roger Lee Whitcomb
>            Priority: Minor
>         Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task 
> already implemented, to do some sort of "checkstyle" processing to evaluate 
> all the code to see where there might be changes to make the code more robust 
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we 
> *should*), but there might be things that would make the code better and 
> easier to read and maintain, and wouldn't take much effort.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to