sruehl commented on a change in pull request #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207197726
########## File path: plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java ########## @@ -58,7 +58,12 @@ public void setUp() { @After public void tearDown() { if(s7PlcConnection.isConnected()) { - s7PlcConnection.close(); + try { + s7PlcConnection.close(); + } catch (NullPointerException e) { Review comment: route cause of failing test is `io.netty.util.concurrent.BlockingOperationException` and only NPE gets caught so the test still fails ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services