sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207198435
##########
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
##########
@@ -58,7 +58,12 @@ public void setUp() {
@After
public void tearDown() {
if(s7PlcConnection.isConnected()) {
- s7PlcConnection.close();
+ try {
+ s7PlcConnection.close();
+ } catch (NullPointerException e) {
Review comment:
this is thrown on master as well, I justed wrapped the code like this:
```
sendDisconnectRequestFuture.addListener((ChannelFutureListener) future -> {
// Close the session itself.
try {
channel.closeFuture().await();
channel.eventLoop().parent().shutdownGracefully();
} catch (Exception e) {
e.printStackTrace();
}
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
